On Tue, Jun 11, 2019 at 4:58 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > On Sun, Jun 9, 2019 at 6:03 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > Relax the condition that overlayfs supports nfs export, to require > > that i_ino is consistent with st_ino/d_ino. > > > > It is enough to require that st_ino and d_ino are consistent. > > Yes. > > > > > This fixes the failure of xfstest generic/504, due to mismatch of > > st_ino to inode number in the output of /proc/locks. > > > > Fixes: 12574a9f4c9c ("ovl: consistent i_ino for non-samefs with xino") > > Cc: <stable@xxxxxxxxxxxxxxx> # v4.19 > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > --- > > > > Miklos, > > > > TBH, I can't remember why I put the s_export_op condition in the > > first place (can you?), expect for the fact the original bug fix > > was reported on nfsd readdirplus. > > I have no recollection of any issue that would require nfs export. > > I've applied the patch. > Forgot to apply to overlayfs-next or intentionally left for 5.3? Thanks, Amir.