Re: [PATCH] xfstest, overlayfs: Use falloc to make sure a meta copy file got copied up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 4, 2019 at 8:34 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
>
> Overlayfs might copy up data of file on first write of file (and
> not necessarily upon open of file). So call falloc file opened
> with O_RDWR and after that data must have been copied up.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>

> ---
>  tests/overlay/060 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: xfstests-dev/tests/overlay/060
> ===================================================================
> --- xfstests-dev.orig/tests/overlay/060 2018-08-27 11:21:51.811847671 -0400
> +++ xfstests-dev/tests/overlay/060      2019-02-04 11:28:09.023718690 -0500
> @@ -170,7 +170,7 @@ test_common()
>
>         # Trigger data copy up and check absence of metacopy xattr.
>         mount_overlay $_lowerdir
> -       $XFS_IO_PROG -c "open -a $SCRATCH_MNT/$_target"
> +       $XFS_IO_PROG -c "falloc 0 1" $SCRATCH_MNT/$_target >> $seqres.full
>         echo "check properties of data copied up file"
>         check_file_size_contents $SCRATCH_MNT/$_target $_size "$_data"
>         umount_overlay



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux