On Thu, Jan 31, 2019 at 6:24 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > There's some progress: it makes it through xfstests without crashing > or deadlocking. There are still some regressing test cases, but > things definitely look better. > They do! kmemleak detected leaking ovl_readpage_work in ovl_readpage_work_fn() and creator_cred in ovl_direct_IO(). I pushed your patch with the leak fixes to ovl-aops-wip as a testing point. > What remains is ctime/mtime support. > > Also fallocate/copyfile/reflink/etc will need some thought as we need > to not only flush out dirty pages, but in some cases prevent new > faults while the operation is in progress. Well, generic/503 which exercises these corners hangs (503.dmesg attached) > > And after that it needs to be optimized (->readpages() and > ->writepages()), but I think that's the easy part. > And we also need to flush pages on non direct IO cases of ->writepages() and then we can revert: e8d4bfe3a715 ovl: Sync upper dirty data when syncing overlayfs and swoop the grand prize :) Thanks, Amir.
Attachment:
503.demg
Description: Binary data
