On Fri, Nov 30, 2018 at 12:42:38PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > In overlayfs, ovl_remap_file_range calls vfs_clone_file_range on the > lower filesystem's inode, passing through whatever remap flags it got > from its caller. Since vfs_copy_file_range first tries a filesystem's > remap function with REMAP_FILE_CAN_SHORTEN, this can get passed through > to the second vfs_copy_file_range call, which isn't an issue. > Remove the WARN_ON because it's unnecessary. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> This looks ok: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But this also indicates that do_clone_file_range/vfs_clone_file_range are misnamed now, as they are wrappers for the remap_file_range method.
