Re: [PATCH] ovl: fix missing override creds in link of a metacopy upper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 14, 2018 at 3:17 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> On Wed, Nov 14, 2018 at 04:01:34PM +0200, Amir Goldstein wrote:
>> Theodore Ts'o reported a v4.19 regression with docker-dropbox:
>> https://marc.info/?l=linux-fsdevel&m=154070089431116&w=2
>>
>> "I was rebuilding my dropbox Docker container, and it failed in 4.19
>>  with the following error:
>>  ...
>>  dpkg: error: error creating new backup file \
>>               '/var/lib/dpkg/status-old': Invalid cross-device link"
>>
>> The problem did not reproduce with metacopy feature disabled.
>> The error was caused by insufficient credentials to set
>> "trusted.overlay.redirect" xattr on link of a metacopy file.
>>
>
> Thanks Amir for fixiing this. This fix looks good to me.
>
> Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
>
> So this problem happened because looks like kernel enanbled metacopy
> by default (in Kconfig) and thence enabled redirect by default in Kconfig.

OVERLAY_FS_METACOPY is off by default.  So it seems people explicitly
enable it, because it sounds useful :)

Thanks,
Miklos



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux