On Thu, Oct 11, 2018 at 2:34 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > Cyril, > Ping. The affected kernel code as well as fix commits are now in v4.19. Pushed rebased branch to: https://github.com/amir73il/ltp/commits/overlayfs-devel Also, there is an unrelated (besides the word "fadvise") cleanup branch https://github.com/amir73il/ltp/commits/fadvise_cleanup that converts the fadvise tests to newlib. Thanks, Amir. > The following series adds test covergae for readahead() syscall > over overlayfs file and adds test coverage for a specific > posix_fadvise() syscall advice (POSIX_FADV_WILLNEED). > > So far, the posix_fadvise syscall tests in LTP only test for error > conditions, but not functionality. > > The functionality of the advice POSIX_FADV_WILLNEED is identical > to readahead() and since kernel commit 3d8f7615319b ("vfs: implement > readahead(2) using POSIX_FADV_WILLNEED"), the implementations are > also bound together. > > To add test coverage of the advice POSIX_FADV_WILLNEED, I decided not > to duplicate the readahead() functional test and add test cases to > readahead02 that use the POSIX_FADV_WILLNEED implementation. > > Thanks, > Amir. > > Changes since v2: > - Runtime check for readahead/fadvise support > - Abort test case immediately if syscall fail > > Changes since v1: > - Fix bugs in loop invocation of test (i.e. -i 2) > - Address review comments from Jan Stancek > - Make cached_max a global maximum over all test cases > - Improve reliability of overlayfs readahead test case failure > > Amir Goldstein (6): > syscalls/readahead01: Convert to newlib > syscalls/readahead02: Convert to newlib and cleanup > syscalls/readahead02: abort test if readahead syscall fails > syscalls/readahead02: test readahead() on an overlayfs file > syscalls/readahead02: test readahead using posix_fadvise() > syscalls/readahead02: fail test if readahead did not use any cache > > .../kernel/syscalls/readahead/readahead01.c | 119 ++---- > .../kernel/syscalls/readahead/readahead02.c | 339 +++++++++--------- > 2 files changed, 198 insertions(+), 260 deletions(-) > > -- > 2.17.1 >
