On Wed, Oct 31, 2018 at 1:35 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >>> config->redirect_mode = match_strdup(&args[0]); >>> if (!config->redirect_mode) >>> return -ENOMEM; >>> + >>> + /* "redirect_dir=off" implies "metacopy=off" */ >>> + if (strcmp(config->redirect_mode, "off") == 0 || >>> + strcmp(config->redirect_mode, "nofollow") == 0) >>> + config->metacopy = false; >> >> This look completely counter to the 'strict' behavior definition. >> If user specified metacopy=on, we are not allowed to end up with metacopy=off. > > What about "metacopy=on,metacopy=off"? > > What I'm saying is that "metacopy=on,redirect_dir=off" should be > exactly equivalent to the above, if taking the implicit disable rule > into account. In other words: it's a nonsense combination of options, just like the former. If documented, then I don't think this would cause problems. Thanks, Miklos
