On Sat, Oct 27, 2018 at 07:08:11AM -0400, Jeff Layton wrote:
> >
> > - if (file_in->f_inode->i_sb != file_out->f_inode->i_sb)
> > + if (file_in->f_op != &nfs4_file_operations)
> > return -EXDEV;
> > + else {
>
> nit: you don't really need the "else" here since the previous block
> returns
>
> > + struct nfs_client *c_in =
> > + (NFS_SERVER(file_inode(file_in)))->nfs_client;
> > + if (c_in->cl_minorversion < 2)
> > + return -EXDEV;
> > + }
Yeah, but if you don't have the else, then you need to declare the c_in
at the beginning of the function instead of in the new block. Mind you,
if you do that then:
c_in = NFS_SERVER(file_inode(file_in))->nfs_client;
fits on one line, so it does look a bit neater.
