On Tue, Jul 31, 2018 at 12:37 PM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: > Store upper layer's ovl_layer structure and root upper dentry into > ovl_fs sturcture for the upcoming "feature set" feature. "feature set" > feature will read upper layer's feature from upper root dentry and save > feature bit mask into upper layer's ovl_layer structure. > > This patch relpace ->upper_mnt to ->upper_layer and add a helper func > ovl_upper_mnt() to get ->upper_mnt easily. > > Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx> > --- Looks good. One minor fix. > @@ -989,7 +991,14 @@ static int ovl_get_upper(struct ovl_fs *ofs, struct path *upperpath) > > /* Don't inherit atime flags */ > upper_mnt->mnt_flags &= ~(MNT_NOATIME | MNT_NODIRATIME | MNT_RELATIME); > - ofs->upper_mnt = upper_mnt; > + > + err = -ENOMEM; > + ofs->upper_layer = kzalloc(sizeof(struct ovl_layer), GFP_KERNEL); > + if (ofs->upper_layer == NULL) > + goto out; > + > + ofs->upper_layer->mnt = upper_mnt; > + ofs->upperdir = dget(upperpath->dentry); > err = 0; > out: You need to dput(upper_mnt) in case kzalloc fails. Probably better to zalloc into local upper_layer var before clone_private_mount(), kree(upper_layer) on goto out and return 0 instead of fallthough to out: label on success. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
