Re: [xfstests PATCH 0/3] overlay: enhance fsck.overlay test cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/7/30 13:56, Amir Goldstein Wrote:
> On Sat, Jul 28, 2018 at 11:42 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote:
>> Hi All,
>>
>> These are fsck.overlay program related patch set. The first patch correct
>> the exit code of fsck.overlay in the existing 3 test cases, the second
>> patch introduce a stress case to test stability, and the final patch add
>> some exception cases to test exception handling process of fsck.overlay.
>>
>> The fsck.overlay program also was undate at:
>>
>> https://github.com/hisilicon/overlayfs-progs/tree/next
>>
>> All these three patches have been tested with the new fsck.overlay,
>> please review.
>>
> 
> So if Eryu tests your changes without updating to new fsck.overlay,
> tests will start to fail. Is that the expected behavior?
> 
> Right now it may not be a big nuisance, but you should declare which
> is "the official" version of fsck.overlay to test with xfstest -
> is it next? master?
> Probably best if you ask Eryu to hold back on merging changes not
> compatible with current fsck.overlay master, until the master branch
> is updated and would be useful to ANNOUNCE the overlayfs-progs
> updates to the list with the gist of changes.
> 

Hi Amir,
Thanks for your suggestion. I will update these fsck.overlay changes to
master branch and post an ANNOUNCE email.

I originally wanted to wait for some comments, if any, before I update
these changes to fsck.overlay's master branch. I will follow your
suggested steps next time, and will post patch set before update to master
branch if it deserve to review.

Thanks,
Yi.

--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux