> Right, I forgot that unhashing dentry on unlink in an overlayfs thing,
> but that doesn't change my analysis of the problem. You can still get
> an unhashed dentry with ext4 with open_by_handle_at(), just you will
> need to work harder on the reproducer ;-)
>
> This reproducer is plenty enough for reporting the bug and verifying
> the fix.
> Do you intend to send the patch yourself?
> Just include the reproducer in commit message and a phrase along
> the lines of:
>
> The code in cap_inode_getsecurity(), introduced by commit ("Introduce
> v3 namespaced file capabilities"), should use d_find_any_alias() instead
> of d_find_alias() do handle unhashed dentry correctly. This is needed,
> for example, if execveat() is called with an open but unlinked overlayfs
> file, because overlayfs unhashes dentry on unlink.
>
> You should include a Fixes tag and may include Suggested-by tag.
>
Great to see the root cause is identified now.
Thanks a lot of your analysis, detail explanation and suggestions on this issue.
The solution is about all comes from you, but if you proposed, I'm
glad to finish the rest of patch job.
And really appreciated of your patch suggestion, it makes things much easier.
Thanks,
Eddie
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
