On Sat, Jun 2, 2018 at 9:52 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > overlay/016 tests two cases of ro/rw fd data inconsistecies - > one using pread and one using mmap read (i.e. mread). > > The first case will pass as soon as stacked overlay operations > patch set is merged. The second case requires enabling a new opt-in > feature "copy_up_shared" in order to pass. > > Instead of changing the entire test from fail to notrun, split > the two cases into two tests and require the new feature only > for the new test. > > This way, the new test will change from notrun to pass with > stacked overlay operations and the old test will change from > fail to pass. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > --- Eryu, Please hold back on this patch - there seems to be a push back on the "copy_up_shared" feature. It may end up making sense to do the split anyway because case #1 may be resolved in this merge cycle and case #2 only later on, but let's wait to see what gets merged first and then decide. No problem with merging the cleanup patch "overlay: nicer report when features are not supported" Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
