On Fri, May 11, 2018 at 1:41 PM, Eryu Guan <guaneryu@xxxxxxxxx> wrote: > On Wed, May 09, 2018 at 07:22:48PM +0300, Amir Goldstein wrote: >> On Wed, May 9, 2018 at 6:27 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >> > Hi, >> > >> > Please find attached the V2 of the patch. Took care of Amir's comments >> > from previous version. >> > >> > Add tests for metadata only copy up feature. >> > >> > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> >> >> Looks good. >> >> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > > Thanks for the review! > >> >> Just a note to Eryu - >> >> You may want to hold on to this test until metacopy is merged >> or at least staged on Miklos' next branch. > > I'd wait for the patches hit Miklos' tree. > Vivek, This test seems to fail with overlayfs-next on check_file_blocks(). With ext4 underneath, blocks count is bigger than expected by 8 sectors. With xfs+reflink the blocks check also fails with different actual nr of blocks. I think it is generally unreliable to try to compute nr of blocks and fail the test if actual is different than computed. Maybe just check that overlay nr blocks is as the actual lower nr of blocks. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
