On Thu, May 10, 2018 at 11:36 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Thu, May 10, 2018 at 11:19 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> On Mon, May 7, 2018 at 7:40 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >>> >>> + if (d.metacopy) >>> + metacopy = true; >>> + /* >>> + * Do not store intermediate metacopy dentries in chain, >>> + * except top most lower metacopy dentry >> >> I don't get it. We need the bottom most metacopy dentry, not the >> topmost. Am I missing something? > > Okay, it's more complicated. > > 1) there is an upper metacopy dentry: > > - store origin (pointed to by ORIGIN or topmost lower dentry) in stack[0] Ugh. So if there's no ORIGIN, we don't want to store anything in stack[0]. Wondering if we really need the data dentry in the stack... Ah, you add OVL_CONST_INO flag later in the series. Good; then we can just store data dentry in stack[0] if there's no origin. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
