On Tue, May 8, 2018 at 5:26 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Tue, May 08, 2018 at 05:14:42PM +0300, Amir Goldstein wrote: >> On Tue, May 8, 2018 at 3:50 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >> > >> [...] >> > >> > Ok, here is the updated patch. I have not defined quivalent of >> > ovl_real_meta_file() as there are no users. >> > >> > >> > Subject: ovl: Open file with data except for the case of fsync >> > >> > ovl_open() should open file which contains data and not open metacopy >> > inode. With the introduction of metacopy inodes, with current implementaion >> > we will end up opening metacopy inode as well. >> > >> > But there can be certain circumstances like ovl_fsync() where we >> > want to allow opening a metacopy inode instead. >> > >> > Hence, change ovl_open_realfile() and ovl_open_real() and add extra >> > parameter which specifies whether to allow opening metacopy inode or not. >> > If this parameter is false, we look for data inode and open that. >> > >> > This should allow covering both the cases. >> > >> > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> >> >> Nice! much shorter. You can add >> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> >> >> BTW, I have never given that much thought, but I see that you >> added Reviewed-by before Signed-off-by in some of the patches >> and after SOB in other patches. >> Of course it doesn't really matter and there isn't a single convention >> in the kernel, but the way I always thought about it is: >> You sign-off at the bottom on the complete work including all the tags >> may have added. > > I was thinking about it and looked at some of the kernel commits and > there seem to be a mix. There does not seem to be a fixed convention > on the order of these tags. > > My take away was that they seem to be ordered FIFO order. So I > do my Signed-off-by:, then you have your Reviewed-by and when > Miklos merges these, he will put his sign-off-by. > > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx> > > If you do not disagree with above, I will make order of Reviewed-by > consistent in whole series and push again metacopy-next branch. > I am fine with the above. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
