Re: [PATCH 3/3] ovl: Use splice_with_holes in copy_up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 08, 2018 at 09:16:46AM +1000, Dave Chinner wrote:
> This sort of whacky undefined behaviour w.r.t. sparseness was the
> reason we were given at LSFMM for cp and rsync not implementing
> copy_file_range() - they could not control it according to the
> user's direction. Hence my suggestion that we need flags to
> specifically direct the behaviour of the syscall so that userspace
> will actually use it....

They can just use SEEK_HOLE/DATA and just copy the chunk they care
about.  Especially as they already have the SEEK_HOLE/DATA logic
for the plain old copy anyway - that is the only thing they have
to create holes in the destination file to start with.  Nevermind
that a file system with inline dedup will happily create holes for
them underneath.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux