On Thu, Apr 26, 2018 at 12:10 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > When user chose the option of copying up a file when mmap(MAP_SHARED) > happens, then do full copy up and not just metacopy. > > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> + nit > --- > fs/overlayfs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c > index be531b79d2e5..d61c8355b892 100644 > --- a/fs/overlayfs/file.c > +++ b/fs/overlayfs/file.c > @@ -304,7 +304,7 @@ static int ovl_pre_mmap(struct file *file, unsigned long prot, > * later. > */ > if ((flag & MAP_SHARED) && ovl_copy_up_shared(file_inode(file)->i_sb)) > - err = ovl_copy_up(file_dentry(file)); > + err = ovl_copy_up_flags(file_dentry(file), O_WRONLY); Either add comment or use wrapper ovl_full_copy_up(). Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html