[PATCH] ovl: copy up files with incompatible xattrs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Fabian Vogt <fvogt@xxxxxxxx>

xattrs are not guarantees to be compatible across different filesystems.
Operations which lead to copying of files to the upper layer fail with an
"Operation not supported" error from the filesystem if a xattr could not be
written in the upper layer. We can safely ignore "system" xattrs.

One easy to hit example is using NFS as a read-only lower layer and !NFS as
upper layer to store changes. Files on NFS can have the "system.nfs4_acl"
xattr set to make the full information available to userspace, but it cannot
be written to on other filesystems.

Signed-off-by: Fabian Vogt <fvogt@xxxxxxxx>
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
---
 fs/overlayfs/copy_up.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index d855f508fa20..e7662e9664be 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -125,6 +125,10 @@ int ovl_copy_xattr(struct dentry *old, struct dentry *new)
 			continue; /* Discard */
 		}
 		error = vfs_setxattr(new, name, value, size, 0);
+		if (error == -EOPNOTSUPP && strncmp("system.", name, 7) == 0) {
+			error = 0;
+			continue; /* Discard */
+		}
 		if (error)
 			break;
 	}
-- 
2.16.2

--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux