Re: question of copying stack in ovl_lookup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Amir,

Thanks for explanation!


> 在 2018年4月10日,下午1:38,Amir Goldstein <amir73il@xxxxxxxxx> 写道:
> 
> On Tue, Apr 10, 2018 at 4:29 AM, cgxu519@xxxxxxx <cgxu519@xxxxxxx> wrote:
>> Hi guys,
>> 
>> I’m a little curious for below code in ovl_lookup, is there any background for
>> copy stack instead of directly using it?
>> 
>> memcpy(oe->lowerstack, stack, sizeof(struct ovl_path) * ctr);
>> 
> 
> Memory compaction.
> 
> stack has ofs->numlower entries, which could be very large,
> but after lookup, oe->numlower can end up being much much
> smaller. Also, ovl_alloc_entry() packs lowerstack together with
> ovl_entry, so the overall memory usage of the long lived overlay
> dentry cache entries is lower.
> 
> Cheers,
> Amir.

--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux