On Mon, Apr 2, 2018 at 3:32 PM, cgxu519@xxxxxxx <cgxu519@xxxxxxx> wrote: [...] >> What you gain is shorter and more generic code to print the error: >> "overlayfs: option %s cannot be changed on remount" >> AND >> "overlayfs: option %s cannot be added on remount” > > I’m wondering how we deal with the case which is specifying same option > several times in a remount. More specifically current lowerdir=aaa and > specify options -o remount,lowerdir=bbb,lowerdir=aaa,ro then if we fail > at first different value, it seems we will break compatibility with mount > in parsing options. > I don't think we should care. if user does that on purpose user should get an error. only if user does something sane, like mount -o remount,lowerdir=bbb and mount command reorders that in a weird way we may need to handle this case. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
