On Tue, Mar 6, 2018 at 10:54 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> When we create a hardlink to a metacopy upper file, first the redirect
> on that inode. Path based lookup will not work with newly created link
> and redirect will solve that issue.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> ---
> fs/overlayfs/dir.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
> index b955f6fede06..da5c4b8ee919 100644
> --- a/fs/overlayfs/dir.c
> +++ b/fs/overlayfs/dir.c
> @@ -24,6 +24,8 @@ module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
> MODULE_PARM_DESC(ovl_redirect_max,
> "Maximum length of absolute redirect xattr value");
>
> +static int ovl_set_redirect(struct dentry *dentry, bool samedir);
> +
> int ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
> {
> int err;
> @@ -468,6 +470,9 @@ static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
> const struct cred *old_cred;
> struct cred *override_cred;
> struct dentry *parent = dentry->d_parent;
> + struct dentry *hardlink_upper;
> +
> + hardlink_upper = hardlink ? ovl_dentry_upper(hardlink) : NULL;
IMO it would be nicer to pass overlay hardlink dentry all the way to
ovl_create_real() and then just:
if (hardlink) {
err = ovl_do_link(ovl_dentry_upper(hardlink), dir,
newdentry, debug);
Thanks,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
