Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Fixes: 061701540349 ("ovl: lookup indexed ancestor of lower dir") Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> --- Miklos, Another fix, for yet another issue reported by 0-day robot. At least it looks like the smatch checker got to the last patch ;-). All 3 fixes over overlayfs-next are push to branch ovl-nfs-export on my github. Thanks, Amir. fs/overlayfs/export.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/overlayfs/export.c b/fs/overlayfs/export.c index bb94ce9da5c8..07d70255095b 100644 --- a/fs/overlayfs/export.c +++ b/fs/overlayfs/export.c @@ -355,8 +355,8 @@ static struct dentry *ovl_lookup_real_inode(struct super_block *sb, dput(upper); } - if (!this) - return NULL; + if (IS_ERR_OR_NULL(this)) + return this; if (WARN_ON(ovl_dentry_real_at(this, layer->idx) != real)) { dput(this); -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html