On 2018/1/18 15:13, Amir Goldstein Wrote: > On Thu, Jan 18, 2018 at 5:50 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: >> +/* Count merge dir and redirect dir in a specified directory */ >> +static int ovl_count_unreal(struct scan_ctx *sctx) > > I am amused by this name :) > FYI, the legacy term used for a directory that is NOT a merge directory > is "pure", such as "pure upper" or "pure lower". > > Confusingly, the "impure dir" term is not exactly the opposite > of the legacy "pure dir" term, but really is a shortcut for > "dir that contains non pure entries". > We could have called the xattr "impurities", but we (I) didn't. > > So, basically, merge and redirect dir are "impurities", > which make the parent dir "impure". > > See for example: > void ovl_dentry_version_inc(struct dentry *dentry, bool impurity) > > 'impurity' refers to merge/redirect children of parent, > kind of like this scan function, so I propose either: > ovl_count_impurities() > OR > ovl_count_impure() > Ha, I've thouht it for a long time, but still cannot find a proper word. Because I think 'impure' may confuse with the meaning of directory with impure xattr. Now, the 'impurities' looks great, thanks! :) > I realize that there is overlap in the term with ovl_count_origin(), > which also counts impurities, but still.. Right, origin target is also a kind of impurities, I will improve this. Thanks, Yi. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
