Re: [PATCH v2 23/23] ovl: copy up of disconnected dentries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 11, 2018 at 4:47 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> On Thu, Jan 4, 2018 at 5:40 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>> With NFS export, some operations on decoded file handles (e.g. open,
>> link, setattr, xattr_set) may call copy up with a disconnected non-dir.
>> In this case, we will copy up lower inode to index dir without
>> linking it to upper dir.
>
> Did we not have plans to link-up from index on lookup, when upper link
> is missing?  For consistency sake, that would make a lot of sense
> after such a disconnected copy-up, and also for the hardlink copy-up.
>
> Yes, things work without the upper link, but restoring the upper link
> makes sense, and lookup is perhaps the most logical place to do that
> restoration.
>

Indeed, disconnected copy-up is a lot like hardlink copy-up+unlink.
I guess the link-up on lookup is independent of the series, but should
be doable.

Thanks,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux