Re: [PATCH v2 14/23] ovl: index all files on copy up with 'verify=on'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 9, 2018 at 6:45 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> On Thu, Jan 04, 2018 at 06:40:09PM +0200, Amir Goldstein wrote:
>> With the 'verify' feature enabled, all files are indexed on copy up.
>> The copy up origin inode of an indexed non-dir can be used as a unique
>> identifier of the overlay object.
>>
>> This is going to be used for NFS export.
>>
>> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
>> ---
>>  fs/overlayfs/util.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
>> index 0254d7f0d401..f40351dcea7b 100644
>> --- a/fs/overlayfs/util.c
>> +++ b/fs/overlayfs/util.c
>> @@ -491,6 +491,10 @@ bool ovl_need_index(struct dentry *dentry)
>>       if (!lower || !ovl_indexdir(dentry->d_sb))
>>               return false;
>>
>> +     /* Index all files for unique origin verification */
>> +     if (!d_is_dir(lower) && ovl_verify(dentry->d_sb))
>> +             return true;
>
> If all files are indexd up with verify=on, what is this check about
> "!d_is_dir()"?
>


Removed by next patch that implements indexing of dir on copy up.

Thanks,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux