On Tue, Jan 9, 2018 at 6:28 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Thu, Jan 4, 2018 at 5:40 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> With the 'verify' feature enabled, when overlay inode nlink drops to >> zero, instead of removing the index entry, replace it with a whiteout >> index entry. >> >> This is needed for NFS export in order to prevent future open by handle >> from opening the lower file directly. > > Just thinking out loud: how could we get rid of index whiteouts in the > "rm -rf" case? Only way is if encoding parent as well, and we > recursively check for a whiteout in the ancestors. Probably not > worth bothering with in the first version, but later maybe? > Right. Current implementation already checks for whiteout in ancestors for dir file handles, so in theory, cleanup of dir whiteouts is not far from reach, except for the fact that decoding dir file handles is expensive, so every cleanup attempt is going to cost. For non-dir this is a more complicated. If you encode parent (i.e. connectable file handle) then for lower hardlinks you find a specific parent, but not all hardlink parents. Anyway, maybe later. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
