On Wed, Nov 29, 2017 at 5:54 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> Hi,
>
> Please find attached V9 of the patches. Minor changes to take care of
> Amir's comments. I have also dropped RFC tag. If there are no concerns,
> then I would like these patches to be included.
>
Sorry Vivek, just realized some issues:
1. Considering Miklos' commit
438c84c2f0c7 ovl: don't follow redirects if redirect_dir=off
It is probably not a good idea to allow lookup of metacopy unless
metacopy=on. Is that already the behavior in V9?
2. An upper layer with metacopy cannot be rotated as middle layer
becasue non-dir origin is only followed from upper layer.
This needs to be fixed (follow origin of metacopy from middle layer).
3. You really should write some tests to verify correctness of
metadata before requesting to include the feature.
I recommend that you start with a simple xfstest that verify expected
behavior of a some basic use cases with
_require_scratch_feature metacopy.
Then, I suggest that you look into extending unionmount-testsuite's
check_layer() to know about metacopy. Currently it checks that
objects that were supposed to be copied up (dentry.copied_up())
are on upper layer (dentry.on_upper()). It shouldn't be too hard to
extend that with dentry.data_copied_up() and dentry.data_on_upper().
to verify metacopy correctness.
Alas, there are currently no chmod/chown test cases in
unionmount-testsuite, so you will also need to add some test cases.
To properly test metacopy in middle layers (once it is implemented)
you can use ./run --ov=N. Currently, to verify redirect_dir,
upper layer is rotated on mkdir and rename dir. You will need
to add some relevant "rotate points" for the metacopy use cases.
For example, I added rotate and recycle points for testing
handlinks/index:
c427e85 - Cycle mount after link rename of non dir
I never got around to the TODO item
https://github.com/amir73il/overlayfs/wiki/Overlayfs-TODO#testing
"unionmount-testsuite configure rotate points"
I envisioned something like:
./run --ov=N rotate=mkdir,rename recycle=link
Instead of the hardcoded rotate/recycle points.
Well, you don't need to implement ALL of that ;-)
Cheers,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
