On Fri, Jan 5, 2018 at 8:33 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Fri, Jan 05, 2018 at 06:42:09PM +0200, Amir Goldstein wrote: [...] >> > >> > So for non-dir case, we check origin by default and error out if decoding >> > of fh fails. Why not do the same thing for directories as well. I mean >> > why directory origin check should be hidden behind a mount option >> > (verfiy=). >> > >> >> Because it is a change of behavior so we need users to opt-in for it. >> When copying layers, file handles become stale. > > But do we support copying layers? Because in that case non-dir > fh will become stale. So that suggests that we don't support it > already. Its perfectly fine if cannot decode origin for non-dir. it is not an error. just won't use lower inode number. > >> As a result, inode numbers of non-dir are taken from upper, but after >> copying inode numbers change anyway, so the implication is moot. > > With metadata copy, implications are very significant again. Right, but with metadata copy you cannot copy layers. > >> You cannot say the same for copied merge dirs with origin that becomes >> stale. The implication of not following lower dir after copying are significant. > > It really feels odd that we will have different behavior for dir and > non-dir objects when it comes to origin verification. Will a new > mount option say verify_origin=on/off make sense. That way this is verify > specific and verifies origin (both for dir and non-dir objects) and user > will opt in to maintain backward compatibility. > I can go with renaming verify to verify_origin. Let's see what Miklos has to say. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
