On Thu, Jan 4, 2018 at 8:42 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Thu, Jan 04, 2018 at 06:39:57PM +0200, Amir Goldstein wrote: >> For non-upper overlay mount, the value of index mount option is moot. >> When mounter tries to set this mount options, emit a warning and leave >> the value at the default so it won't show up in /proc/mounts. > > I am curious, what should show in /proc/mounts. Current code seems to > print this only if it is different from default. > I guess that is a common pattern for filesystems only show options that are different from default. I think the logic is that one would try to reconstruct mounts from a snapshot of /proc/mounts, there is no reason to specify values that are default, because resulting mount will be the same. > So if detfault is index=on, and user specifies index=off (with no upper), > it should still show in /proc/mounts? > What this patch says is that index is not a relevant option with no upper, so basically specifying either index=on/off is wrong, but so does specifying workdir and the action that overlay takes is ignoring the wrong option. I realize the setting index to default (on) when there is no upper is a bit hacky, but I think we can live with that in order to keep the parsing code simple and storing only a boolean single state. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
