> > 在 2017年12月18日，下午5:15，Amir Goldstein <amir73il@xxxxxxxxx> 写道： > > On Mon, Dec 18, 2017 at 11:01 AM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote: >> If upper fs supports tmpfile, check link ability between >> upperdir and workdir and print a warning message if check >> fails. >> >> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxx> > > Code looks good, but missing some commentary. > > Please mention in commit message as well as in comment above code > that the motivation for the check is different project id. > >> --- >> Changes since v1: >> - Check link ablity between upperdir and workdir instead of checking >> project ids of upperdir and workdir. >> - Print a warning message instead of falling to readonly mode. > > Not that I care too much, but did you choose not to fallback to read-only? In my case, it’s better directly to fallback to read-only, but I think in some other use cases maybe only write to upperdir and do not modify anything on lowerdirs. Thanks, Chengguang. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
