On Thu, Dec 7, 2017 at 12:19 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Wed, Nov 29, 2017 at 3:01 AM, Chengguang Xu <cgxu@xxxxxxxxxxxx> wrote: >> When executing filesystem sync or umount on overlayfs, >> dirty data does not get synced as expected on upper filesystem. >> This patch fixes sync filesystem method to keep data consistency >> for overlayfs. > > Do we really need to export __sync_filesystem()? > > Just skipping wait == 0 and calling sync_filesystem() for wait == 1 > should be equivalent. > > Fixed up patch queued. Let me know if I missed something... > Looks right to me. There is even a bonus - emergency_sync() will invoke a single __sync_filesystem(sb, 0) underlying fs regardless of the number of mounted overlayfs. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html