Re: [PATCH v2 3/3] generic/470: add syncfs test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> 在 2017年12月7日,上午11:04,Amir Goldstein <amir73il@xxxxxxxxx> 写道:
> 
> On Thu, Dec 7, 2017 at 4:22 AM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote:
>> Inspired by syncfs bug of overlayfs which does not sync dirtyinodes in
>> underlying filesystem.
>> Run syncfs and shutdown filesystem(or underlying filesystem of overlayfs)
>> to check syncfs result.
>> 
>> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxx>
>> ---
>> 
>> Changes since v1:
>> Use fs shutdown and fssum to check syncfs result instead of
>> checking delalloc state of extents.
>> 
>> tests/generic/470     | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++
>> tests/generic/470.out |  2 ++
>> tests/generic/group   |  1 +
>> 3 files changed, 91 insertions(+)
>> create mode 100755 tests/generic/470
>> create mode 100644 tests/generic/470.out
>> 
>> diff --git a/tests/generic/470 b/tests/generic/470
>> new file mode 100755
>> index 0000000..b488747
>> --- /dev/null
>> +++ b/tests/generic/470
>> @@ -0,0 +1,88 @@
>> +#! /bin/bash
>> +# FS QA Test 470
>> +#
>> +# Inspired by syncfs bug of overlayfs which does not sync dirty inodes in
>> +# underlying filesystem.
>> +#
>> +# Run syncfs and shutdown filesystem(or underlying filesystem of overlayfs)
>> +# to check syncfs result.
>> +#
>> +# Test will be skipped if filesystem(or underlying filesystem of overlayfs)
>> +# does not support shutdown.
>> +#
>> +#-----------------------------------------------------------------------
>> +# Copyright (c) 2017 Chengguang Xu <cgxu519@xxxxxxxxxx>
>> +# All Rights Reserved.
>> +#
>> +# This program is free software; you can redistribute it and/or
>> +# modify it under the terms of the GNU General Public License as
>> +# published by the Free Software Foundation.
>> +#
>> +# This program is distributed in the hope that it would be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program; if not, write the Free Software Foundation,
>> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
>> +#-----------------------------------------------------------------------
>> +#
>> +
>> +seq=`basename $0`
>> +seqres=$RESULT_DIR/$seq
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +_cleanup()
>> +{
>> +       cd /
>> +       rm -f $tmp.*
>> +}
>> +
>> +# get standard environment, filters and checks
>> +. ./common/rc
>> +. ./common/filter
>> +
>> +# remove previous $seqres.full before test
>> +rm -f $seqres.full
>> +
>> +# real QA test starts here
>> +
>> +_supported_fs generic
>> +_supported_os Linux
>> +_require_test
>> +_require_fssum
>> +_require_scratch
>> +_require_scratch_shutdown
>> +_require_xfs_io_command "syncfs"
>> +
>> +
>> +FCNT=1000
>> +
>> +_scratch_mkfs >/dev/null 2>&1
>> +_scratch_mount
>> +
>> +# In order to mitigate interference of write-back,
>> +# create many files for test.
>> +for i in `seq 1 $FCNT`; do
>> +       $XFS_IO_PROG -f -c "pwrite 1K 1M" \
>> +               $SCRATCH_MNT/$i >/dev/null 2>&1
>> +done
>> +
>> +$FSSUM_PROG -ugomAcdES -f -w $TEST_DIR/before_test $SCRATCH_MNT
>> +$XFS_IO_PROG -c "syncfs" $SCRATCH_MNT/${FCNT} >/dev/null 2>&1
>> +_scratch_shutdown
>> +_scratch_cycle_mount
>> +$FSSUM_PROG -ugomAcdES -f -w $TEST_DIR/after_test $SCRATCH_MNT
>> +diff $TEST_DIR/before_test $TEST_DIR/after_test
> 
> Just FYI, md5sum can take multiple files so this can be written as:
> 
> md5sum $SCRATCH_MNT/$i > $TEST_DIR/before_test
> ...
> md5sum -c $TEST_DIR/before_test > /dev/null 2>&1
> 
> Which reads a lot simpler to me.  At least I don't know what 'ugomAcdES'
> stands for and for this simple use case I probably don't need to know.
> 

Hmm, fssum seems better than md5sum for metadata check, as it’s usage shows below.
If short comment of fssum option is acceptable, I prefer to keep it. How do you think? 


$ ./fssum  -h
usage: fssum <options> <path>
  options:
    -f          : write out a full manifest file
    -w <file>   : send output to file
    -v          : verbose mode (debugging only)
    -r <file>   : read checksum or manifest from file
    -[ugoamcde] : specify which fields to include in checksum calculation.
         u      : include uid
         g      : include gid
         o      : include mode
         m      : include mtime
         a      : include atime
         c      : include ctime
         d      : include file data
         e      : include open errors (aborts otherwise)
         s      : include block structure (holes)
    -[UGOAMCDES]: exclude respective field from calculation
    -n          : reset all flags
    -N          : set all flags
    -x path     : exclude path when building checksum (multiple ok)
    -h          : this help

The default field mask is ugoamCdES. If the checksum/manifest is read from a
file, the mask is taken from there and the values given on the command line
are ignored.


Thanks,
-cgxu--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux