On Tue, Nov 28, 2017 at 2:39 PM, Chengguang Xu <cgxu@xxxxxxxxxxxx> wrote: > Executes filesystem sync or umount on overlayfs, When executing... > dirty data does not be synced as expected on upper filesystem. ...does not get synced... > This patch fixes sync filesystem method to keep data consistency > for overlayfs. > > Signed-off-by: Chengguang Xu <cgxu@xxxxxxxxxxxx> > > --- > Chengguang, This patch looks fine, but it is not based on overlayfs-next nor on master. I guess by "mainline" you meant latest release or something. Please rebase V4 on overlayfs-next from Miklos' tree. I enhanced my origin syncfs test to check for syncing of upper files: https://github.com/amir73il/overlayfs/blob/master/tests/xfs_syncfs.sh Without your fix, the upper file delalloc blocks are not flushed after syncfs, but only after fsync. With your fix delalloc blacks are flushed by syncfs. Can you take the task to make this simple test into an xfstest? If you need help finding your way around xfstests, I can help you with that. You do not need the xfs specific parts of the test, only the generic delalloc part. I think it is best to make a generic/* test (i.e. not fs specific), which tests flushing of delalloc blocks on sync/syncfs/fsync for fs that support delalloc, but it may also make sense to have an overlay/* specific regression test for syncfs. We can discuss those details after you post a test. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
