On Mon, Nov 27, 2017 at 5:12 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > Hi Amir, > > I am wondering if this is a bug or it is supposed to be like this. I felt > it is a bug, so I generated a patch and sending it for your review. > Yap. That's a bug. Good catch! I fixed test overlay/033 to catch it. Please add cc:stable # v4.13 and Fixes tag. Thanks! Amir. > Vivek > > > Right now we seem to be passing index as "lowerdentry" and origin.dentry > as "upperdentry". IIUC, we should pass these parameters in reversed order > and this looks like a bug. > > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> > --- > fs/overlayfs/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c > index 625ed8066570..5ef69bc09e0c 100644 > --- a/fs/overlayfs/namei.c > +++ b/fs/overlayfs/namei.c > @@ -435,7 +435,7 @@ int ovl_verify_index(struct dentry *index, struct ovl_path *lower, > > /* Check if index is orphan and don't warn before cleaning it */ > if (d_inode(index)->i_nlink == 1 && > - ovl_get_nlink(index, origin.dentry, 0) == 0) > + ovl_get_nlink(origin.dentry, index, 0) == 0) > err = -ENOENT; > > dput(origin.dentry); -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
