Re: [PATCH] ovl: fix failure to fsync lower dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 22, 2017 at 6:44 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> On Fri, Nov 10, 2017 at 11:10 AM, Raphael Hertzog <raphael@xxxxxxxxx> wrote:
>> Hi Amir,
>>
>> Le mercredi 08 novembre 2017, Amir Goldstein a écrit :
>>> The problem reported by Raphael is that new PostgreSQL 10.0 with a
>>> database in overlayfs where lower layer in squashfs fails to start.
>>> The failure is due to fsync error, when PostgreSQL does fsync on all
>>> existing db directories on startup and a specific directory exists
>>> lower layer with no changes.
>>
>> I confirm that this patch is enough to fix my issue.
>>
>> Tested-by: Raphaël Hertzog <hertzog@xxxxxxxxxx>
>>
>
> Miklos,
>
> Did you miss this one or have any reservations about the patch?

The "od->is_upper = true;" seems to be wrong.  With that the second
fsync() on that file will use the lower file (the od->realfile)
instead of the upper file (od->upperfile).

With that line removed, I think it's OK.  Queued for this cycle.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux