This commit implements similar changes made to overlay/038 test i.e. in addition to checking consistent values of st_ino/d_ino for "." and ".." entries, check also the values for subdir inside each tested directory setup. Signed-off-by: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx> --- tests/overlay/038 | 39 ++++++++++++++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/tests/overlay/038 b/tests/overlay/038 index fd804c4..5415324 100755 --- a/tests/overlay/038 +++ b/tests/overlay/038 @@ -59,7 +59,7 @@ upperdir=$OVL_BASE_SCRATCH_MNT/$OVL_UPPER lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER mkdir -p $lowerdir -mkdir -p $lowerdir/test_dir/pure_lower_dir +mkdir -p $lowerdir/test_dir/pure_lower_dir/subdir touch $lowerdir/test_file @@ -69,10 +69,11 @@ test_dir=$SCRATCH_MNT/test_dir/ # Verify d_ino of '.' and '..' before and after dir becomes impure. impure_dir=$test_dir/impure_dir -mkdir -p $impure_dir +mkdir -p $impure_dir/subdir impure_dir_st_ino=$(stat -c '%i' $impure_dir) impure_dir_parent_st_ino=$(stat -c '%i' $test_dir) +impure_subdir_st_ino=$(stat -c '%i' $impure_dir/subdir) # Before $impure_dir becomes impure parent_d=$($here/src/t_dir_type $impure_dir $impure_dir_parent_st_ino) @@ -83,6 +84,10 @@ current_d=$($here/src/t_dir_type $impure_dir $impure_dir_st_ino) [[ $current_d == ". d" ]] || \ echo "Pure upper dir: Invalid d_ino reported for ." +subdir_d=$($here/src/t_dir_type $impure_dir $impure_subdir_st_ino) +[[ $subdir_d == "subdir d" ]] || \ + echo "Pure upper dir: Invalid d_ino reported for subdir" + # Move a copied up file into pure dir to make it impure mv $SCRATCH_MNT/test_file $impure_dir test_file_st_ino=$(stat -c '%i' $impure_dir/test_file) @@ -100,6 +105,10 @@ current_d=$($here/src/t_dir_type $impure_dir $impure_dir_st_ino) [[ $current_d == ". d" ]] || \ echo "Impure dir: Invalid d_ino reported for ." +subdir_d=$($here/src/t_dir_type $impure_dir $impure_subdir_st_ino) +[[ $subdir_d == "subdir d" ]] || \ + echo "Impure dir: Invalid d_ino reported for subdir" + # Verify copy up file's d_ino file_d=$($here/src/t_dir_type $impure_dir $test_file_st_ino) [[ $file_d == "test_file f" ]] || \ @@ -107,19 +116,23 @@ file_d=$($here/src/t_dir_type $impure_dir $test_file_st_ino) # Make $impure_dir pure rm -rf $impure_dir/test_file +rm -rf $impure_dir/subdir # Verify invalidation of readdir cache $here/src/t_dir_type $impure_dir $test_file_st_ino [[ $? != 0 ]] || echo "Directory's readdir cache has stale file entries" +$here/src/t_dir_type $impure_dir $impure_subdir_st_ino +[[ $? != 0 ]] || echo "Directory's readdir cache has stale subdir entries" impure=$($GETFATTR_PROG --absolute-names --only-values -n 'trusted.overlay.impure' \ $upperdir/test_dir/impure_dir 2>/dev/null) [[ -z $impure ]] || echo "Pure directory has impure xattr" -# Verify d_ino of '.' and '..' before and after dir becomes merge dir. +# Verify d_ino values of subdir entries of a pure lower dir. parent_st_ino=$(stat -c '%i' $test_dir) pure_lower_dir=$SCRATCH_MNT/test_dir/pure_lower_dir pure_lower_dir_st_ino=$(stat -c '%i' $pure_lower_dir) +pure_lower_subdir_st_ino=$(stat -c '%i' $pure_lower_dir/subdir) parent_d=$($here/src/t_dir_type $pure_lower_dir $parent_st_ino) [[ $parent_d == ".. d" ]] || \ @@ -129,6 +142,10 @@ current_d=$($here/src/t_dir_type $pure_lower_dir $pure_lower_dir_st_ino) [[ $current_d == ". d" ]] || \ echo "Pure lower dir: Invalid d_ino reported for ." +subdir_d=$($here/src/t_dir_type $pure_lower_dir $pure_lower_subdir_st_ino) +[[ $subdir_d == "subdir d" ]] || \ + echo "Pure lower dir: Invalid d_ino reported for subdir" + # Create a file in pure lower dir to make it a merge dir touch $pure_lower_dir/newfile @@ -140,6 +157,10 @@ current_d=$($here/src/t_dir_type $pure_lower_dir $pure_lower_dir_st_ino) [[ $current_d == ". d" ]] || \ echo "Merged dir: Invalid d_ino reported for ." +subdir_d=$($here/src/t_dir_type $pure_lower_dir $pure_lower_subdir_st_ino) +[[ $subdir_d == "subdir d" ]] || \ + echo "Merged dir: Invalid d_ino reported for subdir" + _scratch_unmount # Verify pure lower residing in dir which has another lower layer @@ -158,8 +179,7 @@ mkdir -p $lowerdir mkdir -p $upperdir mkdir -p $workdir -mkdir -p $middir/test_dir -mkdir -p $lowerdir/test_dir/pure_lower_dir +mkdir -p $lowerdir/test_dir/pure_lower_dir/subdir _overlay_scratch_mount_dirs "$middir:$lowerdir" $upperdir $workdir @@ -168,10 +188,19 @@ touch $test_dir/test_file test_dir_st_ino=$(stat -c '%i' $test_dir) pure_lower_dir=$test_dir/pure_lower_dir +pure_lower_dir_st_ino=$(stat -c '%i' $pure_lower_dir) +pure_lower_subdir_st_ino=$(stat -c '%i' $pure_lower_dir/subdir) parent_d=$($here/src/t_dir_type $pure_lower_dir $test_dir_st_ino) [[ $parent_d == ".. d" ]] || \ echo "Pure lower in dir which has another lower layer: Invalid d_ino reported for .." +current_d=$($here/src/t_dir_type $pure_lower_dir $pure_lower_dir_st_ino) +[[ $current_d == ". d" ]] || \ + echo "Pure lower in dir which has another lower layer: Invalid d_ino reported for ." + +subdir_d=$($here/src/t_dir_type $pure_lower_dir $pure_lower_subdir_st_ino) +[[ $subdir_d == "subdir d" ]] || \ + echo "Pure lower in dir which has another lower layer: Invalid d_ino reported for subdir" echo "Silence is golden" status=0 -- 2.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html