On Fri, Nov 17, 2017 at 12:03 AM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > During lookup, check for presence of OVL_XATTR_METACOPY and if not present, > set OVL_UPPERDATA bit in flags. This is only done for upper inode with a > corresponding lower dentry and file needs to be a regular file. Basically > any file which is eligible for metadata only copy up. It is not completely clear that "this is only done" refers to the xattr check and not to setting the flag. Suggest to add text like this: "... For the rest of the files, OVL_UPPERDATA flag is set unconditionally if upper inode exists." > > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html