On Mon, Nov 13, 2017 at 04:57:08PM +0200, Amir Goldstein wrote: > On Mon, Nov 13, 2017 at 4:45 PM, Chandan Rajendra > <chandan@xxxxxxxxxxxxxxxxxx> wrote: > > An overlayfs filesystem instance with one lowerdir filesystem and with > > "xino" mount option enabled can have the layer index encoded in the 63rd > > bit of the inode number. A signed 64 bit integer won't suffice to store > > this inode number. Hence this commit uses strtoul() to convert the inode > > number in string form to unsigned integer form. > > > > Signed-off-by: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx> > > Looks good, especially since I had to fix the same problem myself ;) > https://github.com/amir73il/xfstests/commits/overlayfs-devel > > My patch also changes: > > int type = -1; /* -1 means all types */ > - uint64_t ino = 0; > + unsigned long ino = 0; > int ret = 1; > > But I am not sure that is the right thing to do here or what difference it makes I think that strtoul() returns unsigned long, which could be 32bit, and uint64_t is guaranteed to be 64bit size, so I tend to change the ino definition too. But I guess that doesn't matter that much :) Thanks, Eryu > > Amir. > > > --- > > src/t_dir_type.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/t_dir_type.c b/src/t_dir_type.c > > index 76aaa9b..7bba304 100644 > > --- a/src/t_dir_type.c > > +++ b/src/t_dir_type.c > > @@ -85,7 +85,7 @@ main(int argc, char *argv[]) > > break; > > /* no match ends up with type = -1 */ > > if (type < 0) > > - ino = atoll(argv[2]); > > + ino = strtoul(argv[2], NULL, 10); > > } > > > > for ( ; ; ) { > > -- > > 2.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
