On Thu, Nov 9, 2017 at 10:50 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> If file is metacopy only, it is possible that lower is encrypted while
> other is not. In that case, report file as encrypted (despite the fact
> that only data is encrypted while metadata is not).
Better consult ext4 guys or find out which user tools care about this
flag and what they could do in response to this flag.
When I commented that we need to see what do to about all these
flags I just gave encrypted flag as an example.
On a hunch I would say that we need a mask of statx flags that are
readonly attributes of the data itself and that mask should probably
contain encrypted and compressed to begin with.
I don't see a reason for 2 separate patches and certainly not for
2 separate helpers.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> ---
> fs/overlayfs/inode.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index 7ba19a97a8da..15713d4ac2dd 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -66,6 +66,16 @@ int ovl_setattr(struct dentry *dentry, struct iattr *attr)
> return err;
> }
>
> +static void ovl_stat_set_encryption(struct kstat *ustat, struct kstat *lstat) {
> + if (!((lstat->attributes_mask & STATX_ATTR_ENCRYPTED) &&
> + (lstat->attributes & STATX_ATTR_ENCRYPTED)))
> + return;
> +
> + ustat->attributes |= STATX_ATTR_ENCRYPTED;
> + ustat->attributes_mask |= STATX_ATTR_ENCRYPTED;
> +}
> +
This looks buggy. you set STATX_ATTR_ENCRYPTED even if lower
doesn't have STATX_ATTR_ENCRYPTED in attributes nor in attributes_mask.
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
