On Mon, Nov 6, 2017 at 12:08 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Mon, Nov 6, 2017 at 11:35 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> On Thu, Nov 2, 2017 at 9:38 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>> For non-samefs case, all directory entries are "impure" because the >>> st_ino value returned from stat(2) is not the st_ino value of the >>> real inode. >>> >>> In order to provide the same d_ino values for the directory type entries, >>> we never iterate the real dir directly in non-samefs case. >>> >>> ovl_fill_real() has been modified to return the overlay inode number >>> as d_ino of the "." and ".." entries. >>> >>> Build the impure dir cache for non-samefs case even if there is no >>> "impure" xattr on dir, but if real dir has nlink > 2 or nlink == 1, >>> which indicates that is has subdirs. >>> >>> Update non-merge dir cache version on every change in subdir entry >>> and reset the dir cache after copy up when directory becomes !is_real. >>> >> >> I don't really like this. Non-samefs d_ino will always be hacky, >> whether consistent with st_ino or not (it loses the uniqueness >> property of d_ino, that is guaranteed in a normal filesystem). >> >> Spending possibly large amounts of memory and CPU cycles to achieve >> consistency is dubious. Especially since nobody seems to be >> complaining about it. >> >> So, I'd just drop 6/8 and 8/8. >> > > Sure, that's fine by me. > I need to fix the get_name() issue regardless. > On second thought, we should keep Chandan's change to return correct d_ino for ".". I will post a trimmed down and fixed version of his patch instead of 8/8. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
