On Wed, Nov 1, 2017 at 5:12 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: > On 2017/11/1 5:45, Amir Goldstein Wrote: >> Miklos, >> >> Let's call my previous version v5 (Zhangyi's last post was v4). >> >> Changes since v5: >> - Split ovl_check_empty_and_clear() changes from bug fix patch >> - Cache "origin" xattr of non-merge dir in inode flag OVL_WHITEOUTS >> (OVL_ORIGIN would have been too confusing) >> - Replace layer idx with is_upper boolean >> >> I tested these changes with upstream xfstest overlay/031 by Zhangyi. >> Pushed to ovl-whiteouts branch [1] and rebased the non-samefs patches >> on top of it [2]. >> > > All these three patches looks good to me, and I tested these too. > Thanks for review and testing! Oh! I messed up the authorship of your patch when I split it. Pushed fixed version with description of my changes to [1]. Miklos, Please take updated commits from my branch. Thanks, Amir. >> >> [1] https://github.com/amir73il/linux/commits/ovl-whiteouts >> [1] https://github.com/amir73il/linux/commits/overlayfs-devel >> >> Amir Goldstein (3): >> ovl: no direct iteration for dir with origin xattr >> ovl: simplify ovl_check_empty_and_clear() >> ovl: fix rmdir problem on non-merge dir with origin xattr >> >> fs/overlayfs/dir.c | 18 ++++++++++------ >> fs/overlayfs/inode.c | 5 +++++ >> fs/overlayfs/overlayfs.h | 4 ++++ >> fs/overlayfs/readdir.c | 56 ++++++++++++++++++++++++++++++++++++++---------- >> fs/overlayfs/util.c | 13 +++++++++++ >> 5 files changed, 79 insertions(+), 17 deletions(-) >> > -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html