Is this really necessary?
"ovl_entry.h" is supposed to be more of a low level thing, and I'm not
sure having that proliferate to all parts of the code is a good idea.
At least some justification would be good here.
Thanks,
Miklos
On Mon, Oct 30, 2017 at 9:27 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> ---
> fs/overlayfs/copy_up.c | 1 -
> fs/overlayfs/inode.c | 1 -
> fs/overlayfs/namei.c | 1 -
> fs/overlayfs/overlayfs.h | 1 +
> fs/overlayfs/super.c | 1 -
> fs/overlayfs/util.c | 1 -
> 6 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
> index c441f9387a1b..9311d183b532 100644
> --- a/fs/overlayfs/copy_up.c
> +++ b/fs/overlayfs/copy_up.c
> @@ -22,7 +22,6 @@
> #include <linux/ratelimit.h>
> #include <linux/exportfs.h>
> #include "overlayfs.h"
> -#include "ovl_entry.h"
>
> #define OVL_COPY_UP_CHUNK_SIZE (1 << 20)
>
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index 03f0ec2b73eb..50e233ccca53 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -14,7 +14,6 @@
> #include <linux/posix_acl.h>
> #include <linux/ratelimit.h>
> #include "overlayfs.h"
> -#include "ovl_entry.h"
>
> int ovl_setattr(struct dentry *dentry, struct iattr *attr)
> {
> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
> index 63200578ce5b..de2dac98e147 100644
> --- a/fs/overlayfs/namei.c
> +++ b/fs/overlayfs/namei.c
> @@ -15,7 +15,6 @@
> #include <linux/mount.h>
> #include <linux/exportfs.h>
> #include "overlayfs.h"
> -#include "ovl_entry.h"
>
> struct ovl_lookup_data {
> struct qstr name;
> diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h
> index 4fa30633780d..73ef1e850635 100644
> --- a/fs/overlayfs/overlayfs.h
> +++ b/fs/overlayfs/overlayfs.h
> @@ -9,6 +9,7 @@
>
> #include <linux/kernel.h>
> #include <linux/uuid.h>
> +#include "ovl_entry.h"
>
> enum ovl_path_type {
> __OVL_PATH_UPPER = (1 << 0),
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index f5738e96a052..8702803ba328 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -18,7 +18,6 @@
> #include <linux/seq_file.h>
> #include <linux/posix_acl_xattr.h>
> #include "overlayfs.h"
> -#include "ovl_entry.h"
>
> MODULE_AUTHOR("Miklos Szeredi <miklos@xxxxxxxxxx>");
> MODULE_DESCRIPTION("Overlay filesystem");
> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
> index 51ca8bd16009..9158d17bb320 100644
> --- a/fs/overlayfs/util.c
> +++ b/fs/overlayfs/util.c
> @@ -17,7 +17,6 @@
> #include <linux/namei.h>
> #include <linux/ratelimit.h>
> #include "overlayfs.h"
> -#include "ovl_entry.h"
>
> int ovl_want_write(struct dentry *dentry)
> {
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
