On Mon, Oct 16, 2017 at 4:24 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Sat, Oct 14, 2017 at 09:05:17AM +0300, Amir Goldstein wrote: > > [..] >> > When I read memory-barrier.txt, it seems to suggest that RELEASE can let >> > instructions outside critical region sneak into critical region. If that's >> > the case, actually clearing of metaflag can happen before xattr actually >> > got removed. Though I can't think what will go wrong in that case. >> >> clear_bit takes a spinlock so I *think* clearing of flag cannot sneak >> before removing xattr. > > Which spinlock does clear_bit take? Are you referring to ovl_inode->lock mutex? > See set_bit() and clear_bit() in include/asm-generic/bitops/atomic.h -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
