On Wed, Sep 27, 2017 at 04:05:49PM +0800, Eryu Guan wrote: > On Wed, Sep 27, 2017 at 10:50:46AM +0300, Amir Goldstein wrote: > > On Wed, Sep 27, 2017 at 10:04 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > Tests that use _overlay_mount_dirs() should also use the > > > default overlay mount options. > > > > Vivek, Eryu, > > > > I should make a disclaimer here: I did not test with SELINUX_MOUNT_OPTIONS > > because I have no SELinux in my test setup. > > > > Specifically, I am concerned that tests that compose "special" overlay mounts, > > like tmpfs mounts and stacked overlay mounts (overlay/029) may not play well > > with SELINUX_MOUNT_OPTIONS applied to the special mounts. > > I am less concerned about the tests that were converted to use > > _overlay_scratch_mount_dirs() helper. > > > > Can either of you run a -g overlay/quick test with this series and valid > > SELINUX_MOUNT_OPTIONS? > > Sure, I'll do the testings anyway, and I have selinux enabled on my test > vms. I just finished a '-g auto' run with OVERLAY_MOUNT_OPTIONS="-o index=on" and selinux enabled, and the results look fine, all failures are known issues. Thanks for the work! Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
