Re: [PATCH 3/8] ovl: Provide a mount option metacopy=on/off for metadata copyup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 06, 2017 at 10:01:47PM +0300, Amir Goldstein wrote:

[..]
> > @@ -441,6 +461,12 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
> >                 config->workdir = NULL;
> >         }
> >
> > +       /* As of now metacopy=on is dependent on index=on */
> > +       if (config->metacopy && !config->index) {
> > +               pr_warn("overlayfs: can not enable metadata only copyup with index=off. Falling back to metacopy=off\n");
> > +               config->metacopy = false;
> > +       }
> > +
> 
> There are later places in fill_super where index may be falling back to off
> due to missing file handle support in lower fs.
> Please move this check to much later to make sure metacopy=on and index=off
> cannot co-exists.

Sure, I missed that. Will fix it.

Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux