On Fri, Oct 6, 2017 at 6:13 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Mon, Oct 02, 2017 at 10:40:07PM +0300, Amir Goldstein wrote: >> On Mon, Oct 2, 2017 at 4:40 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >> > If an inode has been copied up metadata only, then we need to query the >> > size from lower and fill up the stat->size. >> >> So you won't need this patch if you copy st_size on metadata_copy, >> which seems like the logical thing to do. >> Thinking very far into the future when METACOPY and ORIGIN will >> be able to share page mappings, they will have to start with the same size. > > Hi Amir, > > What about "st_blocks"? After metadata copy up, doing stat on overlay file > shows "st_blocks" as 0. I think I still will need to intervene and get > st_blocks from lower file instead? > Yeh, I guess you would. BTW, if it were up to me I would prefer a single call to vfs_getattr() instead of one for STATX_INO and then another for STATX_BLOCKS. Even though current code queries STATX_INO only for samefs case, there are patches by Chandan to relax samefs in ovl_getattr(). Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
