On Mon, Jul 31, 2017 at 12:58 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Sat, Jul 29, 2017 at 12:33 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > >> One thing that stands out in "my" patch ("ovl: constant d_ino across copy up") >> The comments and commit message claim "When all layers are on the same fs", >> but the patch doesn't actually checks that. > > I does in ovl_cache_update_ino(). That check would be more logical > in ovl_calc_d_ino(), though. Fixed. > I see the patches in overlayfs-next still don't have the ovl_same_sb() test in ovl_calc_d_ino(). I don't really mind. BTW, do you intend to apply/rework Chandan's non-samefs patches for next? if so, the current location of ovl_same_sb() really doesn't matter.. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html