Re: [PATCH 10/10] ovl: follow decoded origin file handle of merge dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 24, 2017 at 11:48 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> On Fri, Jul 14, 2017 at 12:58 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
>> If you don't want to bundle index=on with NFS export, then no rush to merge
>> these patches now. The added benefit on patch 9 (retroactive marking merge
>> dir with origin for not exposing whiteouts) is relevant to a patch that is not
>> going to land in v4.13 anyway. right?
>
> Right.
>
> Can we maybe postpone the verification until fh decode time?

Not sure I follow.
Failure to verify lower dir can result in merge dir not being merged or being
merged with a different lower dir (followed by fh).

The question is which inode we choose to encode in case lower dir cannot be
verified: the unverified lower inode, the stored origin inode or the
upper inode.

Are you suggesting that "normal" lookup will merge the unverified lower dir
and then a pair of encode/decode will result in another dentry?
or are you suggesting to return ESTALE in that case?
If latter, then that error we be permanent? encode/decode will alway end up
with ESTALE??

Please explain.

Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux