[PATCH v2 0/2] overlayfs forward compat index changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Miklos,

I did not get any NACK nor ACK from you on the patch:
[08/10] ovl: do not cleanup directory and whiteout index entries
from the v4.13 assorted fixes series.

So I've NACKed it myself, because we should not be allowing
rw mount with index entries from the future.

So patch 1 is resend of that patch which returns EROFS from
ovl_indexdir_cleanup() if entries from the future are found.
I'll leave it to you to decide if this error translates to
mount failure or fallback to read-only mount.

Patch 2 takes care of another forward compact issue related
index entries from the future in ovl_lookup_index(), but it
is really a sanity check that we should have had there (we
forgot to check that found index is of same file type as lower).

FYI, I have a WIP for whiteout index implementation at [1]
with these patched:
  ovl: verify directory and whiteout index entries
  ovl: whiteout index on last unlink

Thanks,
Amir.

[1] https://github.com/amir73il/linux/commits/ovl-index-wip

Amir Goldstein (2):
  ovl: do not cleanup directory and whiteout index entries
  ovl: check for bad and whiteout index on lookup

 fs/overlayfs/namei.c   | 41 ++++++++++++++++++++++++++++++++---------
 fs/overlayfs/readdir.c |  5 ++++-
 2 files changed, 36 insertions(+), 10 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux