[bug report] ovl: hash overlay non-dir inodes by copy up origin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Miklos Szeredi,

This is a semi-automatic email about new static checker warnings.

The patch b9ac5c274b8c: "ovl: hash overlay non-dir inodes by copy up
origin" from Jul 4, 2017, leads to the following Smatch complaint:

fs/overlayfs/inode.c:603 ovl_get_inode()
	 warn: variable dereferenced before check 'lowerdentry' (see line 600)

fs/overlayfs/inode.c
   599		if (!realinode)
   600			realinode = d_inode(lowerdentry);
                                            ^^^^^^^^^^^
Old dereference.

   601	
   602		if (!S_ISDIR(realinode->i_mode) &&
   603		    (upperdentry || (lowerdentry && ovl_indexdir(dentry->d_sb)))) {
                                     ^^^^^^^^^^^
New check added here.

   604			struct inode *key = d_inode(lowerdentry ?: upperdentry);
   605			unsigned int nlink;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux